Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server: hide internal structure #424

Merged
merged 3 commits into from
Dec 5, 2021
Merged

Server: hide internal structure #424

merged 3 commits into from
Dec 5, 2021

Conversation

aliemjay
Copy link
Member

@aliemjay aliemjay commented Dec 2, 2021 •
edited by robjtede
Loading

PR Type

Refactor

PR Checklist

Check your PR fulfills the following:

  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

Overview

Hide implementation details of Server.

@aliemjay aliemjay added the server Actix server label Dec 2, 2021
@aliemjay aliemjay mentioned this pull request Dec 4, 2021
Merged
4 tasks
robjtede
robjtede approved these changes Dec 5, 2021
View reviewed changes
Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this if you are

@aliemjay
Copy link
Member Author

aliemjay commented Dec 5, 2021 •
edited
Loading

I'm happy with this if you are

of course I am.
What made you think the opposite? :)

@robjtede
Copy link
Member

robjtede commented Dec 5, 2021

What made you think the opposite

no changelog entry ;)

@robjtede robjtede merged commit 8c4ec34 into actix:master Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjtede robjtede robjtede approved these changes

Assignees
No one assigned
Labels
server Actix server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aliemjay @robjtede